fix: ensure scheduled runs always use latest splunk version by poojpat2 · Pull Request #459 · splunk/addonfactory-workflow-addon-release

poojpat2 · 2026-01-29T18:13:37Z

Description

Fix scheduled runs incorrectly executing on all supported Splunk versions.

github-actions · 2026-01-29T18:13:51Z

CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

poojpat2 · 2026-01-30T06:45:44Z

I have read the Code of Conduct and I hereby accept the Terms

poojpat2 · 2026-01-30T06:45:55Z

recheck

mkolasinski-splunk · 2026-02-03T11:20:27Z

@poojpat2 please provide links to test runs, best for couple of scenarios:

scheduled run
PR towards main
PR towards develop
push towards develop

mkolasinski-splunk · 2026-02-03T11:08:55Z

.github/workflows/reusable-build-test-release.yml

          features: PYTHON39
      - id: determine_splunk
-        env:
-          wfe_run_on_splunk_latest: ${{ inputs.wfe-run-on-splunk-latest }}


If this is removed, then input inputs.wfe-run-on-splunk-latest is never referenced in the workflow, meaning it's reduntant.

Example run supposed to run on all Splunk versions supported: https://github.com/splunk/test-addonfactory-repo/actions/runs/21628063395

https://github.com/splunk/test-addonfactory-repo/blob/refs/heads/mkolasinski-splunk-patch-3/.github/workflows/build-test-release.yml#L29

poojpat2 · 2026-02-03T17:46:00Z

All the jobs are working as per description mentioned in jira.
The details of the executed jobs are provided below:

scheduled run : https://github.com/splunk/test-addonfactory-repo/actions/runs/21639249437
PR towards main : https://github.com/splunk/test-addonfactory-repo/actions/runs/21636162587
PR towards develop :https://github.com/splunk/test-addonfactory-repo/actions/runs/21635836696
push towards develop : https://github.com/splunk/test-addonfactory-repo/actions/runs/21635912203
https://github.com/splunk/test-addonfactory-repo/actions/runs/21664018661 (when explicitly forced to true)

mbruzda-splunk · 2026-02-05T10:39:01Z

.github/workflows/reusable-build-test-release.yml

+          if [[ "${{ github.event_name }}" == "schedule" ]]; then
+            wfe_run_on_splunk_latest="true"
+          elif [[ "$wfe_run_on_splunk_latest" == "true" ]]; then
+            wfe_run_on_splunk_latest="true"


This checks if wfe_run_on_splunk_latest is equal to true, and if it is, it sets wfe_run_on_splunk_latest to true again?

Explicit input=true ALWAYS forces latest

If the variable is already true, this just sets it to true again, so it’s effectively a no op

In the calling workflow if dveloper/other user explicitly provide "wfe_run_on_splunk_latest=true" input then below condition will trigger in the sceduled jobs.

elif [[ "$wfe_run_on_splunk_latest" == "true" ]]; then
wfe_run_on_splunk_latest="true"

mbruzda-splunk · 2026-02-05T10:40:05Z

.github/workflows/reusable-build-test-release.yml

      - name: run-btool-check
        id: run-btool-check
-        timeout-minutes: 10
+        timeout-minutes: 20


I don't think this change is related to fixing schedule runs. Please create a separate branch for this. Let's not set a practice to work on everything on a single branch

Okay.I will create seperate branch.

mbruzda-splunk · 2026-02-05T10:55:50Z

.github/workflows/reusable-build-test-release.yml

        required: false
        description: "Forces WFE tests to run only on the latest Splunk when set to true. When set to false - will run on all supported Splunk versions required for the release. When not set - default behavior."
        type: string
        default: "false"


This variable is set to false by default

yes it's set to "false" only

mbruzda-splunk · 2026-02-05T10:56:37Z

.github/workflows/reusable-build-test-release.yml

        env:
          wfe_run_on_splunk_latest: ${{ inputs.wfe-run-on-splunk-latest }}
-        run: |
-          if [[ "$wfe_run_on_splunk_latest" == "" ]]; then


Right now wfe_run_on_splunk_latest is set to false at the top of the workflow, so this condition never passes

Correct, the previous logic never recalculated because the input defaulted to false, which is why the condition was refactored to explicitly evaluate branch and event instead of relying on an empty value.

mbruzda-splunk · 2026-02-05T10:56:55Z

.github/workflows/reusable-build-test-release.yml

          wfe_run_on_splunk_latest: ${{ inputs.wfe-run-on-splunk-latest }}
-        run: |
-          if [[ "$wfe_run_on_splunk_latest" == "" ]]; then
-            wfe_run_on_splunk_latest="${{  github.event_name == 'schedule' || !((github.base_ref == 'main' || github.ref_name == 'main') || ((github.base_ref == 'develop' || github.ref_name == 'develop')  && github.event_name == 'push')) }}"


Because the variable is never empty, this block never runs and the value is never recalculated based on the branch or event. That means the logic below is effectively skipped every time

Agreed, this was the core issue, and the fix ensures the value is always recomputed based on schedule, input, branch, and event as required by Jira.

Do you think wfe_run_on_splunk_latest would be calculated correctly if we actually reached this code block?

I think this is old commit which is removed this empty input code in the latest finalized commit.

.github/workflows/reusable-build-test-release.yml

mbruzda-splunk · 2026-02-05T12:12:23Z

.github/workflows/reusable-build-test-release.yml

+          elif [[ "$wfe_run_on_splunk_latest" == "true" ]]; then
+            wfe_run_on_splunk_latest="true"
+          elif [[ "${{ github.base_ref }}" == "main" || "${{ github.ref_name }}" == "main" ]] || \
+                [[ ("${{ github.base_ref }}" == "develop" || "${{ github.ref_name }}" == "develop")]]; then


This line has a syntax bus in bash script. [[ ( is fine, but you’re missing spaces and you have )]] jammed together. This might work anyway, but readability suffers

I’ll correct the spacing in the condition to improve readability.

mbruzda-splunk · 2026-02-09T08:51:24Z

.github/workflows/reusable-build-test-release.yml

+          elif [[ "$wfe_run_on_splunk_latest" == "true" ]]; then
+            wfe_run_on_splunk_latest="true"


Suggested change

elif [[ "$wfe_run_on_splunk_latest" == "true" ]]; then

wfe_run_on_splunk_latest="true"

These two lines look redundant, please remove them

Thanks for the review. I’ve removed the redundant lines as suggested.

poojpat2 requested a review from a team as a code owner January 29, 2026 18:13

mkolasinski-splunk requested changes Feb 3, 2026

View reviewed changes

poojpat2 changed the title ~~Fix Splunk version for scheduled jobs~~ fix(ci): ensure scheduled runs always use latest splunk version Feb 4, 2026

mbruzda-splunk reviewed Feb 5, 2026

View reviewed changes

poojpat2 changed the title ~~fix(ci): ensure scheduled runs always use latest splunk version~~ fix: ensure scheduled runs always use latest splunk version Feb 6, 2026

mbruzda-splunk reviewed Feb 9, 2026

View reviewed changes

mbruzda-splunk approved these changes Feb 9, 2026

View reviewed changes

mkolasinski-splunk approved these changes Feb 10, 2026

View reviewed changes

poojpat2 and others added 15 commits February 10, 2026 17:17

changes made for scheduledruns

ec895d4

Add workflow scheduler runs

e744612

Added workflow scheduler runs

f8138a5

changes made for scheduled

acb2b8b

changes done for scheduled

729eb0b

changes did for scheduled workflow

281a30b

changes did for workflow

2d95cc8

Added fix workflow scheduler runs

d47313c

Added fix for btool timeout

b8988e7

Added fix for btool

4ddbfe5

Added fix

583d119

changes done for workflow

829d381

changes did for workflow1

d1a040c

changes did for workflow2

4f5c3ca

removed redundant condition

0b70226

poojpat2 force-pushed the workflow_scheduleruns branch from 47a89f6 to 0b70226 Compare February 10, 2026 11:50

poojpat2 merged commit b632e94 into develop Feb 11, 2026
6 checks passed

poojpat2 deleted the workflow_scheduleruns branch February 11, 2026 09:21

github-actions bot locked and limited conversation to collaborators Feb 11, 2026

		elif [[ "$wfe_run_on_splunk_latest" == "true" ]]; then
		wfe_run_on_splunk_latest="true"

Conversation

poojpat2 commented Jan 29, 2026

Description

Uh oh!

github-actions bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

poojpat2 commented Jan 30, 2026

Uh oh!

poojpat2 commented Jan 30, 2026

Uh oh!

mkolasinski-splunk commented Feb 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poojpat2 commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbruzda-splunk Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poojpat2 Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mbruzda-splunk Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 29, 2026 •

edited

Loading

poojpat2 commented Feb 3, 2026 •

edited

Loading

mbruzda-splunk Feb 5, 2026 •

edited

Loading

poojpat2 Feb 5, 2026 •

edited

Loading

mbruzda-splunk Feb 5, 2026 •

edited

Loading